-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup patterns #56
Cleanup patterns #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep as sdk, likewise other paths should also start using absolute paths at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Segfaultd told me the opposite :p
Can we agree on a way to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relative paths are ugly, especially when they need to step out more than 2 times out of current dir, like ../../../foo/bar.h
, where a single sdk/foo/bar.h
would usually suffice, it's a suggestion though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm with the idea of at scale taking the SDK out of MafiaMP project and making it standalone for any other project that might use it (trainer etc...).
So if we can minimize the setup required to use it (and by setup I mean creating absolute paths), isn't it better?
Open discussion @zpl-zak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ye in that case it's fine, but let's only do that in SDK code only, please.
Just to add I'm ok with it when the included file is next to you #include "other.h"
or above dir #include "../baz.h"
, but it gets messy in some other cases.
a5e4a17
to
1f7b8df
Compare
- Remove Addr on some names - Use hook::get_pattern instead of hook::pattern().get_first() - Remove useless utils/hooking/hooking.h import - Moving pattern to dedicated file if it was not there
1f7b8df
to
acc56bd
Compare
Summary
Addr
suffix on some nameshook::get_pattern()
instead ofhook::pattern().get_first()
utils/hooking/hooking.h
import (already imported inpattern.h
)__
(2 underscores) between class name and attributes