Skip to content

Commit

Permalink
MM² Main core use node >= v20 // delete node v18 from test suite (#3463)
Browse files Browse the repository at this point in the history
  • Loading branch information
bugsounet authored Jun 19, 2024
1 parent 6332445 commit bc27c46
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/automated-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
timeout-minutes: 30
strategy:
matrix:
node-version: [18.x, 20.x, 22.x]
node-version: [20.x, 22.x]
steps:
- name: "Checkout code"
uses: actions/checkout@v4
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/electronRebuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,17 @@ jobs:
rebuild:
name: Run electron-rebuild
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [20.x, 22.x]
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: "Use Node.js ${{ matrix.node-version }}"
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
check-latest: true
- name: Install MagicMirror
run: npm run install-mm
- name: Install @electron/rebuild
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,12 @@ _This release is scheduled to be released on 2024-07-01._

### Removed

- [test suite] delete node v18 support

### Updated

- [chore] Update dependencies including electron to v30
- [core] use node >= v20

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
"electron": "^30.1.0"
},
"engines": {
"node": ">=18"
"node": ">=20"
},
"_moduleAliases": {
"node_helper": "js/node_helper.js",
Expand Down

0 comments on commit bc27c46

Please sign in to comment.