Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock can be off by a minute #2030

Closed
Martin-Palringo opened this issue May 27, 2020 · 2 comments
Closed

Clock can be off by a minute #2030

Martin-Palringo opened this issue May 27, 2020 · 2 comments

Comments

@Martin-Palringo
Copy link

With MagicMirror (confirmed on 2.11.0), when the clock module is configured to show only minutes, it updates every minute. This update, however, does not correctly happen on (or just after) the minute changes - so the displayed time often drifts to be a minute out from the real time.

eg. time is 22:15, MM2 shows 22:14.

I would propose calculating how long is left till the next minute, setting the next setTimeout to refresh the clock shortly after the next minute happens.

@rejas
Copy link
Collaborator

rejas commented May 31, 2020

That seems reasonable. Would you be able to send a PR for this or do you need help`with it?

@Martin-Palringo
Copy link
Author

I'm happy to send a PR - hopefully I'll get a moment to do this in the next few days.

MichMich added a commit that referenced this issue Jul 1, 2020
Fix #2030 - Clock can be off by a minute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants