Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove degree symbol for Kelvin scale #1505

Merged

Conversation

fwitte
Copy link
Contributor

@fwitte fwitte commented Jan 3, 2019

As discussed in #1503, temperature displays are e. g.

  • 25 °C,
  • 112 °F or
  • 360 K.

Also, I changed the appropriate source code for both, currentweather and weatherforecast, in order to align with each other.

@MagicMirrorBot
Copy link

Warnings
⚠️

Please include an updated CHANGELOG.md file.
This way we can keep track of all the contributions.

Generated by 🚫 dangerJS

@MichMich
Copy link
Collaborator

MichMich commented Jan 3, 2019

Can you please add an updated CHANGELOG.md? Thanks!

@MichMich MichMich merged commit 675c937 into MagicMirrorOrg:develop Jan 3, 2019
@fwitte
Copy link
Contributor Author

fwitte commented Jan 5, 2019

@balassy Thanks for your suggestion, I did not consider that being a problem. I will adjust the changes to match the changes applied to the new weather module. The behavior will then be:

scale/degreeLabel: true -> "°F", "°C", "K"

scale/degreeLabel: false ->"°", "°", ""

@balassy
Copy link
Contributor

balassy commented Jan 5, 2019

@fwitte Thank you very much, Francesco, I appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants