weather module adjustments for rain and snow #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the update to the new weather module with some refactoring of rain and snow. I've kept them separate in case in the future there is desire to split it out. For now, both will be added together into precipitation property of weatherobject. I think precipitation is a better way to reflect the data from the various APIs. I've added some comments to the provider js so that others can understand what is/isnt in the JSON in terms of precipitation. Ex: DarkSky doesnt give back rainfall, but it does for snowfall.
showPrecipitationAmount is the new flag. I've set it back to default false as this was the behavior in the weatherforecast module.