Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fullday/showend conflict #2629 #2829

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Conversation

sdetweil
Copy link
Collaborator

  1. Base your pull requests against the develop branch.
    yes
  2. Include these infos in the description:
  • What does the pull request accomplish? Use a list if needed.
    adds else clause
    if showend, then skip check for fullday event
  • If it includes major visual changes please add screenshots.
    no visual changes
  1. Don't forget to add an entry about your changes to
    the CHANGELOG.md file.
    updated

@codecov-commenter
Copy link

Codecov Report

Merging #2829 (cdd8743) into develop (a143ebc) will decrease coverage by 0.35%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2829      +/-   ##
===========================================
- Coverage    65.26%   64.91%   -0.36%     
===========================================
  Files            8        8              
  Lines          285      285              
===========================================
- Hits           186      185       -1     
- Misses          99      100       +1     
Impacted Files Coverage Δ
js/server.js 66.21% <0.00%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a143ebc...cdd8743. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants