Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for configuring FontAwesome class in calendar-module: #2949

Merged

Conversation

MagMar94
Copy link
Contributor

Some icons in FontAwesome, like the Facebook-logo, requires a different class than fas fa-fw fa-. Added support for specifying the className:

{
    symbol: "facebook-square",
    symbolClassName: "fab fa-",
    url: "https://www.facebook.com/events/ical/upcoming/?uid=<some_uid>"
}

Magnus Marthinsen added 3 commits October 16, 2022 18:29
Some symbols require a different class name than the hard coded "fas fa-fw fa-". The facebook symbol, for instance, requires "fab fa-".
@rejas
Copy link
Collaborator

rejas commented Oct 16, 2022

Thanks, but could you check why the tests are failing and fix them?

@MagMar94
Copy link
Contributor Author

Thanks, but could you check why the tests are failing and fix them?

Done ✅

@codecov-commenter
Copy link

Codecov Report

Merging #2949 (482c468) into develop (7bbf8c1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2949   +/-   ##
========================================
  Coverage    64.06%   64.06%           
========================================
  Files            9        9           
  Lines          295      295           
========================================
  Hits           189      189           
  Misses         106      106           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rejas
Copy link
Collaborator

rejas commented Oct 16, 2022

Looks good. COuld you also create a PR for this new option in the Doc repo (https://github.com/MichMich/MagicMirror-Documentation/) for the calendar page (https://docs.magicmirror.builders/modules/calendar.html#configuration-options)

@rejas rejas merged commit 835c893 into MagicMirrorOrg:develop Oct 16, 2022
@MagMar94 MagMar94 deleted the bugfix/facebook-icon-does-not-work branch October 16, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants