Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure smhi provider api only gets a maximimum of 6 digits coordinates #2956

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Make sure smhi provider api only gets a maximimum of 6 digits coordinates #2956

merged 2 commits into from
Oct 24, 2022

Conversation

rejas
Copy link
Collaborator

@rejas rejas commented Oct 21, 2022

Fixes #2955

@rejas rejas changed the base branch from master to develop October 21, 2022 07:06
@rejas
Copy link
Collaborator Author

rejas commented Oct 24, 2022

Although the original issue got closed since it was unrelated to this PR, it should still get merged. The API doesnt like 6 digit lat/lon:
https://opendata-download-metfcst.smhi.se/api/category/pmp3g/version/2/geotype/point/lon/15.12345678/lat/56.12345678/data.json

Shorting the lat/lon parameters works like expected:
https://opendata-download-metfcst.smhi.se/api/category/pmp3g/version/2/geotype/point/lon/15.123456/lat/56.123456/data.json

@rejas rejas requested review from khassel and sdetweil October 24, 2022 16:21
@khassel khassel merged commit dde8860 into MagicMirrorOrg:develop Oct 24, 2022
@rejas rejas deleted the issue_2955 branch October 24, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khassel khassel khassel left review comments

@sdetweil sdetweil Awaiting requested review from sdetweil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SMHI isn't working with the weather module
2 participants
@rejas @khassel