Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatenotification: only notify mm-repo for master if tag present #3004

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Jan 14, 2023

see discussion here: #2991 (comment)

I still see a need for updating master in special cases (e.g. correct errors in README.md which would otherwise be present up to 3 month until next release) so with this PR only for MagicMirror repo and only for master branch updatenotifications are only triggered if at least one of the new commits has a tag.

May @MichMich must decide if this is wanted.

…ications if there is no new release tag (only for `master`)
@codecov-commenter
Copy link

Codecov Report

Merging #3004 (04366fb) into develop (877f8ad) will increase coverage by 0.29%.
The diff coverage is 86.48%.

@@             Coverage Diff             @@
##           develop    #3004      +/-   ##
===========================================
+ Coverage    21.94%   22.23%   +0.29%     
===========================================
  Files           51       51              
  Lines        11297    11324      +27     
===========================================
+ Hits          2479     2518      +39     
+ Misses        8818     8806      -12     
Impacted Files Coverage Δ
...s/default/updatenotification/updatenotification.js 0.00% <0.00%> (ø)
modules/default/updatenotification/git_helper.js 89.58% <87.87%> (-0.84%) ⬇️
modules/default/updatenotification/node_helper.js 90.27% <100.00%> (+23.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rejas rejas requested a review from MichMich January 15, 2023 17:18
@MichMich
Copy link
Collaborator

Looks good to me! 👍🏻

Copy link
Collaborator

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it looks good for @MichMich then it looks good for me too :-)

@rejas rejas merged commit 58b9ddc into MagicMirrorOrg:develop Jan 26, 2023
@khassel khassel deleted the mm_master_notification branch February 6, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants