Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup more callback things #3051

Merged
merged 13 commits into from
Feb 26, 2023
Merged

Conversation

rejas
Copy link
Collaborator

@rejas rejas commented Feb 22, 2023

Looks quite stable on my computers, so maybe we give it a try?

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Merging #3051 (880eef3) into develop (b5b6124) will increase coverage by 0.08%.
The diff coverage is 38.01%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop    #3051      +/-   ##
===========================================
+ Coverage    22.99%   23.07%   +0.08%     
===========================================
  Files           52       52              
  Lines        11593    11578      -15     
===========================================
+ Hits          2666     2672       +6     
+ Misses        8927     8906      -21     
Impacted Files Coverage Δ
js/loader.js 0.00% <0.00%> (ø)
js/main.js 0.00% <0.00%> (ø)
js/module.js 0.00% <0.00%> (ø)
js/server.js 95.90% <83.33%> (+0.10%) ⬆️
js/app.js 80.89% <88.88%> (-0.25%) ⬇️
js/node_helper.js 98.61% <100.00%> (-0.01%) ⬇️
modules/default/updatenotification/node_helper.js 90.27% <0.00%> (+12.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

veeck added 2 commits February 25, 2023 22:24
v23 doesnt load calendar, no idea why :-(
@rejas rejas marked this pull request as ready for review February 26, 2023 15:58
@khassel khassel merged commit 1b2785c into MagicMirrorOrg:develop Feb 26, 2023
@rejas rejas deleted the misc/cleanup branch February 26, 2023 18:29
rejas pushed a commit to rejas/MagicMirror that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants