Refactor formatTime into util class #3073
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #3073 +/- ##
===========================================
+ Coverage 27.51% 27.95% +0.43%
===========================================
Files 52 52
Lines 11573 11574 +1
===========================================
+ Hits 3184 3235 +51
+ Misses 8389 8339 -50
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rejas
force-pushed
the
util_formattime
branch
4 times, most recently
from
e4e7ca2 to
c5ba7b5
Compare
rejas
force-pushed
the
util_formattime
branch
3 times, most recently
from
08d8821 to
131a982
Compare
rejas
force-pushed
the
util_formattime
branch
3 times, most recently
from
44084f2 to
276a5a7
Compare
... so that tests can rely on using the same timezone
|
Running tests with times/dates is a PITA ... Had to add an action to the github-actions for setting the timezone, otherwise the tests would fail here (while being fine locally)... |
hopefully this helps ... |
|
now I understood that only the new tests need the timezone (because these tests are now failing on my side). Is there no way to get these test running without needing a specific timezone? Or move them to the |
|
found a jest solution, will provide a new PR ... |
needed for new formatTime unit tests. Avoiding ugly TZ setting in github workflows, see #3073
While looking at #3070 I noticed that the weather and clock module do some formatTime stuff, so why not use a common function for that?