Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weathergov api precipitationLastHour #3125

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

JasonStieber
Copy link
Contributor

Pull request fixes small big in weathergov api format mismatch #3124

@codecov-commenter
Copy link

Codecov Report

Merging #3125 (562efc0) into develop (e985e99) will increase coverage by 0.06%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop    #3125      +/-   ##
===========================================
+ Coverage    25.55%   25.61%   +0.06%     
===========================================
  Files           53       53              
  Lines        11464    11464              
===========================================
+ Hits          2930     2937       +7     
+ Misses        8534     8527       -7     
Impacted Files Coverage Δ
modules/default/weather/providers/weathergov.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@rejas rejas changed the title Develop Fix weathergov api precipitationLastHour Jun 18, 2023
package.json Outdated Show resolved Hide resolved
@khassel
Copy link
Collaborator

khassel commented Sep 9, 2023

@JasonStieber can you make the requested changes?

@rejas
Copy link
Collaborator

rejas commented Jan 18, 2024

pinging @JasonStieber in the hope he picks this PR up again

@khassel
Copy link
Collaborator

khassel commented Jun 22, 2024

Looking into the data getting from the weather gov api there is still a property precipitationLastHour:

grafik

@rejas So we could implement a logical change to use precipitationLast3Hours if precipitationLastHour is null or close this PR.

@rejas
Copy link
Collaborator

rejas commented Jun 24, 2024

@rejas So we could implement a logical change to use precipitationLast3Hours if precipitationLastHour is null or close this PR.

I would vote for the logical change. And you and @sdetweil ?

@khassel
Copy link
Collaborator

khassel commented Jun 27, 2024

I would vote for the logical change.

I implemented this now.

@khassel khassel requested a review from rejas June 27, 2024 21:22
@khassel khassel merged commit c89c3ed into MagicMirrorOrg:develop Jun 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants