Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow custom module positions by setting allowCustomModulePositions… #3506

Merged
merged 1 commit into from
Aug 1, 2024
Merged

allow custom module positions by setting allowCustomModulePositions… #3506

merged 1 commit into from
Aug 1, 2024

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Jul 22, 2024

… in config.js

fixes #3504, related to #3445

@khassel khassel requested a review from rejas July 22, 2024 20:20
@khassel
Copy link
Collaborator Author

khassel commented Aug 1, 2024

@rejas @sdetweil

Can this be merged since I'm not prepared to resolve merge conflicts for weeks here?

It is a minimal solution. If someone wants to invest more, they can do so with a new PR.

@sdetweil
Copy link
Collaborator

sdetweil commented Aug 1, 2024

yes, merge

@rejas rejas merged commit 76d8f98 into MagicMirrorOrg:develop Aug 1, 2024
6 checks passed
@khassel khassel deleted the custom_pos branch August 1, 2024 20:17
@sdetweil sdetweil mentioned this pull request Aug 4, 2024
Merged
khassel pushed a commit that referenced this pull request Aug 27, 2024
@sdetweil
add support for custom regions, by detecting what is used in index.ht…
2b97e0d 
…ml (#3518)

read index.html to discover the regions used, make them the list checked
by app.js and check:config test

fixes #3504   supercedes #3506 

no config.js param required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rejas rejas rejas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khassel @sdetweil @rejas