Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt to canonicalize peer name in Kerberos/GSSAPI/SSPI auth #1166

Closed
wants to merge 1 commit into from

Conversation

elprans
Copy link
Member

@elprans elprans commented Jul 17, 2024

libpq does not canonicalize and neither should we, because:

  1. it's likely the wrong thing to do and removes control from the user;
  2. it introduces a blocking DNS lookup into an async path, which is not
    great.

libpq does not canonicalize and neither should we, because:

1) it's likely the wrong thing to do and removes control from the user;
2) it introduces a blocking DNS lookup into an async path, which is not
   great.
@eltoder
Copy link
Contributor

eltoder commented Jul 18, 2024

Unfortunately, this does not work:

gssapi.raw.misc.GSSError: Major (851968): Unspecified GSS failure.  Minor code may provide more information, Minor (2529638919): Server not found in Kerberos database

But we can make the code follow libpq more closely and remove the gethostbyname_ex call. I'll send a PR.

@eltoder
Copy link
Contributor

eltoder commented Jul 18, 2024

#1167

@elprans elprans closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants