Refactor: some fetcher-related code #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteMinds
requested review from
zhangyouxin,
Daryl-L,
Keith-CY and
PainterPuppets
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WhiteMinds
force-pushed
the
refactor/434_RelatedToFetcher
branch
from
4ad98bb
to
6c4213b
Compare
WhiteMinds
force-pushed
the
refactor/434_RelatedToFetcher
branch
from
6c4213b
to
89d499d
Compare
|
Rebased. |
Keith-CY
approved these changes
Oct 20, 2023
Daryl-L
reviewed
Oct 20, 2023
|
|
||
| if ( | ||
| isAxiosError(error) && | ||
| error.response?.data && |
There was a problem hiding this comment.
Suggested change
| error.response?.data && | |
| error.response && | |
| error.response.data && |
There was a problem hiding this comment.
The type of response here is still Nullable, probably because AxiosError might be thrown before and during the request?
export interface AxiosError<T = any> extends Error {
...,
response?: AxiosResponse<T>;
...,
}
WhiteMinds
force-pushed
the
refactor/434_RelatedToFetcher
branch
from
89d499d
to
860f49f
Compare
|
Rebased. |
WhiteMinds
force-pushed
the
refactor/434_RelatedToFetcher
branch
from
860f49f
to
119d0ea
Compare
|
Rebased. |
WhiteMinds
force-pushed
the
refactor/434_RelatedToFetcher
branch
from
119d0ea
to
b4056f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the types related to fetcher from the components to ExplorerService and index.d.ts, preparing for the next step of refactoring to the models level.