Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inscription): add inscription to the address card #208

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Conversation

Daryl-L
Copy link

@Daryl-L Daryl-L commented Jan 14, 2024

Copy link

vercel bot commented Jan 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 10:14am

@Keith-CY
Copy link
Member

Keith-CY commented Jan 16, 2024

This address received an unknown sudt, but it's not listed
https://ckb-explorer-frontend-in-magickbase-repo-git-tab-magickbase.vercel.app/address/ckt1qrfrwcdnvssswdwpn3s9v8fp87emat306ctjwsm3nmlkjg8qyza2cqgqqypkqx2llypfkk95j65eguhflr9htpxtegp9rdm2
image


It's not listed because the token info is missing

@Daryl-L
Copy link
Author

Daryl-L commented Jan 16, 2024

This address received an unknown sudt, but it's not listed https://ckb-explorer-frontend-in-magickbase-repo-git-tab-magickbase.vercel.app/address/ckt1qrfrwcdnvssswdwpn3s9v8fp87emat306ctjwsm3nmlkjg8qyza2cqgqqypkqx2llypfkk95j65eguhflr9htpxtegp9rdm2 image

It's not listed because the token info is missing

This address received an unknown sudt, but it's not listed https://ckb-explorer-frontend-in-magickbase-repo-git-tab-magickbase.vercel.app/address/ckt1qrfrwcdnvssswdwpn3s9v8fp87emat306ctjwsm3nmlkjg8qyza2cqgqqypkqx2llypfkk95j65eguhflr9htpxtegp9rdm2 image

It's not listed because the token info is missing

image Underline of tab is not aligned

page: https://ckb-explorer-frontend-in-magickbase-repo-git-tab-magickbase.vercel.app/address/ckt1qqfy5cxd0x0pl09xvsvkmert8alsajm38qfnmjh2fzfu2804kq47vqdhk85uk74t6shc4ap7dlh94qrhy795jngsqrm48

I have found this problem, just in progress to fix it.

@Daryl-L
Copy link
Author

Daryl-L commented Jan 16, 2024

This address received an unknown sudt, but it's not listed https://ckb-explorer-frontend-in-magickbase-repo-git-tab-magickbase.vercel.app/address/ckt1qrfrwcdnvssswdwpn3s9v8fp87emat306ctjwsm3nmlkjg8qyza2cqgqqypkqx2llypfkk95j65eguhflr9htpxtegp9rdm2 image
It's not listed because the token info is missing

This address received an unknown sudt, but it's not listed https://ckb-explorer-frontend-in-magickbase-repo-git-tab-magickbase.vercel.app/address/ckt1qrfrwcdnvssswdwpn3s9v8fp87emat306ctjwsm3nmlkjg8qyza2cqgqqypkqx2llypfkk95j65eguhflr9htpxtegp9rdm2 image
It's not listed because the token info is missing

image Underline of tab is not aligned page: https://ckb-explorer-frontend-in-magickbase-repo-git-tab-magickbase.vercel.app/address/ckt1qqfy5cxd0x0pl09xvsvkmert8alsajm38qfnmjh2fzfu2804kq47vqdhk85uk74t6shc4ap7dlh94qrhy795jngsqrm48

I have found this problem, just in progress to fix it.

Wrong comment to reply, the problem I said was this #208 (comment).

And here, all the items from list was listed here, maybe @zmcNotafraid could have a lock.

@Keith-CY
Copy link
Member

This address received an unknown sudt, but it's not listed ckb-explorer-frontend-in-magickbase-repo-git-tab-magickbase.vercel.app/address/ckt1qrfrwcdnvssswdwpn3s9v8fp87emat306ctjwsm3nmlkjg8qyza2cqgqqypkqx2llypfkk95j65eguhflr9htpxtegp9rdm2 image
It's not listed because the token info is missing

This address received an unknown sudt, but it's not listed ckb-explorer-frontend-in-magickbase-repo-git-tab-magickbase.vercel.app/address/ckt1qrfrwcdnvssswdwpn3s9v8fp87emat306ctjwsm3nmlkjg8qyza2cqgqqypkqx2llypfkk95j65eguhflr9htpxtegp9rdm2 image
It's not listed because the token info is missing

image Underline of tab is not aligned page: https://ckb-explorer-frontend-in-magickbase-repo-git-tab-magickbase.vercel.app/address/ckt1qqfy5cxd0x0pl09xvsvkmert8alsajm38qfnmjh2fzfu2804kq47vqdhk85uk74t6shc4ap7dlh94qrhy795jngsqrm48

I have found this problem, just in progress to fix it.

Wrong comment to reply, the problem I said was this #208 (comment).

And here, all the items from list was listed here, maybe @zmcNotafraid could have a lock.

I've compared it with the page on testnet and found the unknown sudt tokens are all not listed.
Then I visited an address which holds some known sudt tokens and they are listed, so I think it's by design

@Keith-CY
Copy link
Member

@FrederLu please have a review

@FrederLu
Copy link

FrederLu commented Jan 16, 2024

https://ckb-explorer-frontend-in-magickbase-repo-8zqec96y0-magickbase.vercel.app/address/ckt1qrejnmlar3r452tcg57gvq8patctcgy8acync0hxfnyka35ywafvkqgp0s624ekepnj9kcezh4vurxg5z0w0zakaqg3cnp0f?tx_status=committed

1、User Defined Tokens copy needs to be updated.
image
image

2、The style appears abnormal when the inscription is long.
image

3、When the page is displayed in Chinese, some styles need to be adjusted.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants