Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rgb++): loading picture when loading #411

Merged
merged 4 commits into from
Aug 14, 2024
Merged

fix(rgb++): loading picture when loading #411

merged 4 commits into from
Aug 14, 2024

Conversation

Daryl-L
Copy link

@Daryl-L Daryl-L commented Aug 1, 2024

Magickbase/ckb-explorer-public-issues#712

/address/tb1qssu8pscsuevnmvhnr08840wvuzdan27k9m46ja

image

image

Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 8:24am

@Keith-CY
Copy link
Member

Keith-CY commented Aug 1, 2024

How do you think about the loading animation? @Sven-TBD

@Sven-TBD
Copy link

Sven-TBD commented Aug 5, 2024

How do you think about the loading animation? @Sven-TBD

It's terrible 🥲, we should come up with another one. @Daryl-L @Kirl70

@Kirl70
Copy link

Kirl70 commented Aug 6, 2024

We can use any of the first three links from this source, just change the color to match the explorer theme color.

https://codepen.io/aurer/pen/ZEJxpO
image

@Keith-CY
Copy link
Member

Keith-CY commented Aug 7, 2024

We can use any of the first three links from this source, just change the color to match the explorer theme color.

codepen.io/aurer/pen/ZEJxpO image

@Sven-TBD please pick one for the loading of the dialog

@Keith-CY
Copy link
Member

Keith-CY commented Aug 8, 2024

Let's use the 3rd one

image

@Keith-CY
Copy link
Member

Keith-CY commented Aug 9, 2024

Let's use the 3rd one

image

Any update on the animation? @Daryl-L

@FrederLu
Copy link

FrederLu commented Aug 9, 2024

https://ckb-explorer-frontend-in-magickbase-repo-7mrdo8pp3-magickbase.vercel.app/xudt/0x5d456d75a00f65d5aed31c180939294464bb158e4c246cf02e62ac6c7fbb4b43
image

The loading state and its styles are implemented.


image

But the second point here has not been processed yet, and there is a RGB++ Digest pop-up window.

image image

Expected style:
image
image

@FrederLu
Copy link

image image

The position of the RGB++ Digest pop-up window on PC has been adjusted, but the problem still exists on mobile devices. Please confirm. @Daryl-L

Comment on lines 6 to 8
<div className={styles.container}>
<SmallSpinner />
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add the class name on SmallSpinner directly?

@Keith-CY Keith-CY added this pull request to the merge queue Aug 14, 2024
Merged via the queue into develop with commit 4bc1e6d Aug 14, 2024
8 checks passed
@Keith-CY Keith-CY deleted the feature/loading branch August 14, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants