Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumericUpDown UseFloatingWatermark Issue #2514

Closed
AndrzejKl opened this issue May 20, 2016 · 12 comments
Closed

NumericUpDown UseFloatingWatermark Issue #2514

AndrzejKl opened this issue May 20, 2016 · 12 comments
Assignees
Labels
Milestone

Comments

@AndrzejKl
Copy link

AndrzejKl commented May 20, 2016

What steps will reproduce this issue?

Just add this to Your MetroWindow:

 <Controls:NumericUpDown Value="40"
                                Controls:TextBoxHelper.Watermark="Watermark:"
                                Controls:TextBoxHelper.UseFloatingWatermark="True" />

With those styles:

<ResourceDictionary.MergedDictionaries>
                <ResourceDictionary Source="pack://application:,,,/MahApps.Metro;component/Styles/Controls.xaml" />
                <ResourceDictionary Source="pack://application:,,,/MahApps.Metro;component/Styles/Fonts.xaml" />
                <ResourceDictionary Source="pack://application:,,,/MahApps.Metro;component/Styles/Colors.xaml" />
                <!-- Accent and AppTheme setting -->
                <ResourceDictionary Source="pack://application:,,,/MahApps.Metro;component/Styles/Accents/Blue.xaml" />
                <ResourceDictionary Source="pack://application:,,,/MahApps.Metro;component/Styles/Accents/BaseLight.xaml" />
            </ResourceDictionary.MergedDictionaries>```

Expected outcome

In this case Floating watermark shows only after pressing plus or minus button.
In my opinion it should work like in TextBox (if value !=null then it's visible)...

Environment

  • MahApps.Metro v1.2.4
  • Windows 10
  • Visual Studio 2013 Pro
  • .NET Framework 4.5
@punker76 punker76 added the Bug label May 20, 2016
@punker76 punker76 added this to the 1.3.0 milestone May 20, 2016
@punker76 punker76 self-assigned this May 20, 2016
@punker76
Copy link
Member

@AndrzejKl thx for reporting, fixed with 1c6480d

@AndrzejKl
Copy link
Author

AndrzejKl commented May 20, 2016

@punker76 Thx, also TextBoxHelper properties aren't visible in Intelisearch in visual Studio for NumericUpDown, like for TextBoxes. It's possible to fix that, R not?

@punker76
Copy link
Member

@AndrzejKl really?

2016-05-20_13h53_54

@AndrzejKl
Copy link
Author

AndrzejKl commented May 20, 2016

@punker76 Yes, really:
image

@punker76
Copy link
Member

@AndrzejKl Is this v1.2.4 ? Can you try the latest pre-release? (note: my last changes are only available tomorrow)

@AndrzejKl
Copy link
Author

@punker76 With 1.3.0.153 (via Nuget) it looks like this:
image

Under CleartextButton, are only 2 more properties: "SelectAllOnFocus" and "TextButton"

@punker76
Copy link
Member

@AndrzejKl Ah, it's not showing, cause you have the Watermark and UseFloatingWatermark already choosen...

@AndrzejKl
Copy link
Author

@punker76 Nope:
image

Btw: Maybe here it's a problem. After chose prerelase version, I have in Designer 2 errors:
image

But I can run it without problems...

@punker76
Copy link
Member

@AndrzejKl @drunkvs try closing vs, deleting obj/bin folders, reopen your solution and rebuild your stuff...

@AndrzejKl
Copy link
Author

@punker76 Thx, errors R gone, but still no watermark and other options in InteliSense...

@punker76
Copy link
Member

@AndrzejKl Ok, found it, 1.3.0-ALPHA154 (available tomorrow) will contain the fix for it

@AndrzejKl
Copy link
Author

THX!

BTW: This project is really nice, good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants