Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyout themes don't care about global theme changes #947

Closed
flagbug opened this issue Jan 17, 2014 · 4 comments
Closed

Flyout themes don't care about global theme changes #947

flagbug opened this issue Jan 17, 2014 · 4 comments
Labels

Comments

@flagbug
Copy link
Member

flagbug commented Jan 17, 2014

Seems that the WindowCommands stay the same when changing the global theme

fuckthis

@AzureKitsune
Copy link
Member

Can you handle the ThemeManager's ThemeChanged event and refresh the WindowCommand's colors?

that picture
Lol

@flagbug
Copy link
Member Author

flagbug commented Jan 17, 2014

The problem is: A flyout listens to the ThemeChanged event as well, but the order of event invocations is not guaranteed, so the window thinks the flyout has the correct theme while it hasn't handled the ThemeChanged event yet

@flagbug
Copy link
Member Author

flagbug commented Jan 17, 2014

Hm, what we can do is: Make a Flyout dumb, let the window be the alone handler of ThemeChanged and tell each Flyout to change its theme

@flagbug
Copy link
Member Author

flagbug commented Jan 17, 2014

It gets better: We can't just loop through the Flyouts because an underlying might have a different theme and closing the upper one doesn't reset the WindowCommands brushes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants