Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WindowCommand brushes when using Flyouts #949

Merged
merged 4 commits into from
Jan 17, 2014

Conversation

flagbug
Copy link
Member

@flagbug flagbug commented Jan 17, 2014

Now with 95% less bugs!

This PR changes the Flyouts so that they are "dumb" and let the host window handle all the color stuff

This fixes the following things:

  • A dark flyout doesn't have dark window commands anymore (lol how did I miss that?)
  • Only the topmost Flyout changes the WindowCommands, if it is closed, the WindowCommands adapt to the underlying Flyout
  • Theme changes are respected
  • Closes Flyout themes don't care about global theme changes #947

What this doesn't fix:

  • My sleep cycle apparently, it's 4 A.M here...

flagbug added a commit that referenced this pull request Jan 17, 2014
Fix WindowCommand brushes when using Flyouts
@flagbug flagbug merged commit db24224 into master Jan 17, 2014
@flagbug flagbug deleted the fix-flyout-windowcommands branch January 17, 2014 11:58
@flagbug flagbug mentioned this pull request Jan 17, 2014
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant