Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1067 #1126

Merged
merged 1 commit into from
Mar 5, 2014
Merged

Fixes #1067 #1126

merged 1 commit into from
Mar 5, 2014

Conversation

Tide
Copy link
Contributor

@Tide Tide commented Mar 5, 2014

I figured out that Blue was the only accent with a darker HighlightColor than the AccentColors. Since all the other accent files had their AccentColor as an alpha of the Highlight color you could not see the AccentColor on top of the HighlightColor. The HighlighColor needed to be a darker color than the accent colors. It is about 26% darker in the blue accent. I modified all other accents to have their HighlightColor be 26% darker than their AccentColor. This seems to fix the issue with GroupBoxes on an accented flyout.

I modified the purple accent to be a little more different than violet. Modified the yellow accent to help with contrast between the highlight and accent colors.

I added a GroupBox to the accent flyout on the flyout demo to illustrate the fixed accents.

I also added a new accent named Taupe.

@Tide
Fixes #1067
b1755b8 
Fixed color issue on all accents except Blue as it was not broke.
Added new Accent named Taupe.
Added GroupBox to Accent Flyout on FlyoutDemo to demonstrate the fixed colors.
@AzureKitsune
Copy link
Member

Excellent work @Tide . Merging this now.

AzureKitsune added a commit that referenced this pull request Mar 5, 2014
@AzureKitsune
Merge pull request #1126 from Tide/1067-tide-accent-color-fix
d7d18df 
Fixes #1067
@AzureKitsune AzureKitsune merged commit d7d18df into MahApps:master Mar 5, 2014
@AzureKitsune AzureKitsune added this to the v0.13 milestone Mar 5, 2014
@AzureKitsune AzureKitsune mentioned this pull request Mar 5, 2014
Closed
@AzureKitsune
Copy link
Member

Hmmm... Dialogs are broken now. I don't know if it was related to this.

@Tide Tide deleted the 1067-tide-accent-color-fix branch March 5, 2014 20:21
@Tide
Copy link
Contributor Author

Tide commented Mar 5, 2014

@Amrykid The dialogs became broken in this commit = f011c3c and this pr = 712ce53

@AzureKitsune
Copy link
Member

@Tide Ninja'd. I realized that a few hours ago in gitter. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v0.13
Development

Successfully merging this pull request may close these issues.
2 participants
@Tide @AzureKitsune