Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to Tile control, #1131

Merged
merged 1 commit into from
Mar 7, 2014
Merged

Fix to Tile control, #1131

merged 1 commit into from
Mar 7, 2014

Conversation

maw136
Copy link

@maw136 maw136 commented Mar 7, 2014

Proper way of setting DefaultStyleKey dependency property for custom control. RTFM.
I will scan through the source for this kind of fixes in other controls.

Current implementation requires code changes in constructors (if you inherit from Tile).

@AzureKitsune
Copy link
Member

It's funny because that is one of the controls that we never look at. I doubt any of the newer controls we have made have that but you're welcome to check. Let me know when you are ready for me to merge this.

@maw136
Copy link
Author

maw136 commented Mar 7, 2014

At work I'm using nuget. I will test the change when I have some spare time, I wrote the code purely on manual and documentation (at least it compiles). Feel free to merge it.

Sent from my Windows Phone


From: Amrykidmailto:notifications@github.com
Sent: ‎2014-‎03-‎07 14:39
To: MahApps/MahApps.Metromailto:MahApps.Metro@noreply.github.com
Cc: maw136mailto:maw136@gmail.com
Subject: Re: [MahApps.Metro] Fix to Tile control, (#1131)

It's funny because that is one of the controls we never look at. I doubt any of the newer controls we made do that but you're welcome to check. Let me know when you are ready for me to merge this.


Reply to this email directly or view it on GitHub:
#1131 (comment)

AzureKitsune added a commit that referenced this pull request Mar 7, 2014
@AzureKitsune AzureKitsune merged commit e913dce into MahApps:master Mar 7, 2014
@AzureKitsune AzureKitsune mentioned this pull request Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants