Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underlined TabControl #1425

Merged
merged 4 commits into from
Jul 15, 2014
Merged

Underlined TabControl #1425

merged 4 commits into from
Jul 15, 2014

Conversation

flagbug
Copy link
Member

@flagbug flagbug commented Jun 14, 2014

  • Add the underline
  • Figure out where we enable this behavior

Fixes #960

2014-06-14 14 33 23 mahapps metro - demo application

@AzureKitsune
Copy link
Member

That's pretty. 👍

@flagbug
Copy link
Member Author

flagbug commented Jun 14, 2014

The only problem now is to figure out where we put the property for the activation of this feature

@laicasaane
Copy link

👍
I think we also need a separate color brush to use with this underline, instead of AccentColorBrush.

@amkuchta
Copy link
Contributor

I think the AccentColorBrush works fine, it is really cohesive. It should match the rest of the TabControl (and window)

@amkuchta
Copy link
Contributor

@flagbug when you say "where to put the property", do you mean on the TabControl vs. the TabItem?

@punker76
Copy link
Member

@flagbug why not a separate style?

@amkuchta
Copy link
Contributor

@punker76 wouldn't a new style have to be created for each "type" of TabControl (i.e. TabControl, MetroAnimatedSingleRowTabControl, MetroAnimatedTabControl)? I see this getting confusing for users very quickly...

Wouldn't it be easier to have a boolean property called UnderlineTabs on the TabControl?

@flagbug
Copy link
Member Author

flagbug commented Jun 26, 2014

@amkuchta We don't own the TabControl class

@amkuchta
Copy link
Contributor

What about an attached property? Something like TabControlHelper.IsUnderlined?

@amkuchta
Copy link
Contributor

@flagbug any updates on this? Don't mean to add any pressure, but I am really interested in this feature for my project (it's gorgeous lol)

@Malavos
Copy link

Malavos commented Jun 30, 2014

Same here. We did our own style for now, but we are looking forward from this.

@amkuchta
Copy link
Contributor

poke? 👉

@Fiasco1216
Copy link

I much prefer the look of this implementation to the current TabControl options. Hopefully this can be merged in soon.

flagbug added a commit that referenced this pull request Jul 15, 2014
@flagbug flagbug merged commit c3d1b50 into master Jul 15, 2014
@flagbug flagbug deleted the underlined-tabcontrol branch July 15, 2014 16:30
@flagbug
Copy link
Member Author

flagbug commented Jul 15, 2014

ControlsHelper.IsUnderlined="True"

There you go

@amkuchta
Copy link
Contributor

For anyone else planning on using this, in order to get the underline to extend across to the edge of your window, you will need to insert a disabled tab with an empty header that is stretched to fill the remaining space in your TabControl

@amkuchta
Copy link
Contributor

Also, @flagbug , this is gorgeous, thank you very much!

@zeluisping
Copy link
Contributor

@amkuchta How exactly, have been trying different ways and didn't manage to achieve that.

@DangerTimsen
Copy link

Hey guys,
nicely done :) How do I get this to work with MetroAnimatedTabControl?

@Brains
Copy link

Brains commented May 11, 2019

How do I get this to work with MetroAnimatedTabControl?

<TabControl mahapps:TabControlHelper.Underlined="SelectedTabItem"/>

TabControlHelper also contains few other related properties:

UnderlineBrush
UnderlineSelectedBrush
UnderlineMouseOverBrush
UnderlineMouseOverSelectedBrush

Sorry for 5 years delay but I just leave it here for future finders (including me)
Because docs https://mahapps.com/controls/tab-control.html contain no info about Underline capability, have found it accidentally

Question
Do more detailed docs (including Underline and similar subtle stuff) exist somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

10 participants