Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flyout close fix #1508

Merged
merged 1 commit into from
Aug 23, 2014
Merged

Flyout close fix #1508

merged 1 commit into from
Aug 23, 2014

Conversation

Dotnetifier
Copy link
Contributor

Fixes #1487.

@mrahhal
Copy link
Contributor

mrahhal commented Aug 19, 2014

Finally! ✌️ ✌️
We can delete all the comments now if you want. And better update the PR description, no useless commits anymore 😄

@Dotnetifier
Copy link
Contributor Author

Yeah. Happy. I felt kinda stupid.

You can delete the comments, I'll do the same in a while. I already saved this page to my files...
I'll update the desciption too and start working on the Floating Watermark branch.

@mrahhal
Copy link
Contributor

mrahhal commented Aug 19, 2014

OK Deleting now.
@flagbug this is ready to be merged.

@Dotnetifier
Copy link
Contributor Author

One more question: I can use Github for Windows now?

@mrahhal
Copy link
Contributor

mrahhal commented Aug 19, 2014

For normal work use the GUI. If you want to manipulate history don't.

@Dotnetifier
Copy link
Contributor Author

OK.

@flagbug flagbug added this to the v1.0 milestone Aug 20, 2014
flagbug added a commit that referenced this pull request Aug 23, 2014
@flagbug
Merge pull request #1508 from Dotnetifier/FlyoutCloseFix
fec8edb 
Flyout close fix
@flagbug flagbug merged commit fec8edb into MahApps:master Aug 23, 2014
@Dotnetifier Dotnetifier deleted the FlyoutCloseFix branch August 23, 2014 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Dotnetifier @mrahhal @flagbug