Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] clear type stuff #1537

Merged
merged 5 commits into from
Sep 4, 2014
Merged

[RFC] clear type stuff #1537

merged 5 commits into from
Sep 4, 2014

Conversation

punker76
Copy link
Member

@punker76 punker76 commented Sep 2, 2014

ClearType partially not working, so this pr should fix some of it

  • TextBox ignores ClearType
  • ComboBox and Menu popup ignores ClearType
    • fix ComboBox ClearType
    • set the correct Effect to enable ClearType (for ComboBox)
    • fix Menu ClearType
    • maybe another Controls too

Benefit

  • we got a ClearType enabled ui

Side effect

  • if we set AllowTransparency="False" for popups, we lost the popup animation, so don't do it :-D

Guidlines, if the user wants clearer text

  • inherite from default style and add this lines
    <Style TargetType="ComboBoxItem"
           BasedOn="{StaticResource MetroComboBoxItem}"
           x:Key="ClearMetroComboBoxItem">
        <Setter Property="TextOptions.TextRenderingMode"
                Value="ClearType" />
        <Setter Property="TextOptions.TextFormattingMode"
                Value="Display" />
    </Style>
Scenarios Recommended Mode
Large Text (15pt+) Ideal \ Display (users preference)
Transformed Text Ideal
Zoomed Text Ideal
Design Scenarios Ideal
Small Text Display

Closes #1536

@punker76 punker76 added this to the v1.0 milestone Sep 2, 2014
@punker76 punker76 self-assigned this Sep 2, 2014
@punker76 punker76 changed the title [WIP][RFC] clear type stuff [RFC] clear type stuff Sep 2, 2014
@punker76
Copy link
Member Author

punker76 commented Sep 2, 2014

@BerndK @mahara testable now...

punker76 added a commit that referenced this pull request Sep 4, 2014
@punker76 punker76 merged commit ef53561 into master Sep 4, 2014
@flagbug flagbug deleted the 1536-punker76-ClearType-stuff branch October 30, 2014 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants