Use correct size for window icon #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punker76
added a commit
that referenced
this pull request
Oct 31, 2014
Use correct size for window icon
|
@thoemmi Wow, nice work, thanks! |
|
I experienced this bug in my own application, so I had to fix it 😉 |
|
I greatly, GREATLY appreciate this!! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1242. A new control
MultiFrameImagereplaces theImagecontrol in theIconTemplate, selecting the best matching icon frame from the provided icon source.To reproduce the fix, remove all image formats from
mahapps.metro.logo2.icoexcept 16x16 and 32x32 (I didn't want to include the modified icon file in this PR 😉) and start the demo application.