fix for #1671 saving window settings #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we should not save settings from hidden windows. also should we respect cancellation
| _window.SourceInitialized -= WindowSourceInitialized; | ||
| _window = null; | ||
| _settings = null; | ||
| if (!e.Cancel) |
There was a problem hiding this comment.
This is unreliable and Cancel will only be true if we're the last subscriber of the Closing event. We should detach this in the Closed event.
- move deregistering events to closed event - handle minimized state changed, because hidden windows gets no window placements
|
Pulled this down and tried with Markdown Edit. Can confirm that it fixes my issue. Thanks. An aside: I did notice that the Title Bar text brush is Black instead of White. Might be an issue or just my build. |
|
@mike-ward the TitleBar text brush is taken from the accent colors (changed after 0.14), e.g. for <Color x:Key="IdealForegroundColor">Black</Color>
<SolidColorBrush x:Key="IdealForegroundColorBrush" Color="{StaticResource IdealForegroundColor}" options:Freeze="True" />you can set the window <SolidColorBrush x:Key="IdealForegroundColorBrush" Color="White" />Another way is to create your own accent. |
punker76
added a commit
that referenced
this pull request
Nov 25, 2014
fix for #1671 saving window settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1671 SaveWindowPosition saves to position 0,0 if window not shown