Fix ideal foreground for some color styles #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here, look at this: http://fs1.directupload.net/images/150111/yvj5n335.png For the most styles, it looks better with a white title (in my opinion)
|
Seems like there's an unrelated change to the input dialog in this PR |
|
Sorry, i've removed that. |
punker76
added a commit
that referenced
this pull request
Jan 11, 2015
Fix ideal foreground for some color styles
|
thx @alkalinee |
|
Hm, this is a "breaking change", at least visually, how should we handle this? |
|
This seems to be happening for a short period of time. The last time I used MA.M [August - September '14] with one of the above accents [Cyan], the text was white. :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, look at this:
For the most styles, it looks better with a white title (in my opinion)