Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Glow to enable drop shadow (EnableDWMDropShadow) #1799

Merged
merged 4 commits into from
Feb 16, 2015

Conversation

punker76
Copy link
Member

after this pr it's possible to have

  • border
    • BorderBrush="{DynamicResource AccentColorBrush}"
  • glow with border
    • GlowBrush="{DynamicResource AccentColorBrush}"
  • glow without border
    • BorderThickness="0"
    • GlowBrush="{DynamicResource AccentColorBrush}"
  • drop shadow
    • BorderThickness="0"
    • GlowBrush="Black"
  • or drop shadow with
    • EnableDWMDropShadow="True"

Closes Window loses shadow [EnableDWMDropShadow] #1791

2015-02-13_15h05_08

@punker76 punker76 added this to the 1.1.0 milestone Feb 13, 2015
@punker76
Copy link
Member Author

@flagbug agreed with this?
/CC @thoemmi @AdditionalPylons

@thoemmi
Copy link
Collaborator

thoemmi commented Feb 15, 2015

Looks ok to me. However, this is a breaking change for applications using EnableDWMDropShadow. Maybe you should add a change handler to EnableDWMDropShadowProperty which, when the property is set to true, sets BorderThickness="0" and GlowBrush="Black".

@punker76
Copy link
Member Author

@thoemmi thx, i also thought about the change handler after did the PR ;-)

@flagbug
Copy link
Member

flagbug commented Feb 16, 2015

Works for me 👍

punker76 added a commit that referenced this pull request Feb 16, 2015
Use the Glow to enable drop shadow (EnableDWMDropShadow)
@punker76 punker76 merged commit 5f7715f into master Feb 16, 2015
@thoemmi
Copy link
Collaborator

thoemmi commented Feb 17, 2015

I would have kept the ObsoleteAttribute on MetroWindow.EnableDWMDropShadow. It's still working under the hood so it's not broken, but users of MahApps.Metro should update their code to set BorderThickness="0" and GlowBrush="Black" directly.

@punker76
Copy link
Member Author

@thoemmi agreed 9ded780

@punker76 punker76 deleted the 1791-EnableDWMDropShadow-fix branch February 19, 2015 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants