Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][RFC] Fix for Glow corners #2143

Merged
merged 7 commits into from
Sep 25, 2015
Merged

[WIP][RFC] Fix for Glow corners #2143

merged 7 commits into from
Sep 25, 2015

Conversation

punker76
Copy link
Member

So, this is my attempt to fix the glow corners.

Current situation (before this PR):

image

image

And now (with this PR):

image

image

image

  • rewrite glow templates (don't use margin, cause inner border flickers in horizontal and vertical direction on resizing, margins... ts)
  • fix show non active glow border brush

Closes #2118 Glow border is missing the corners

/cc @thoemmi @flagbug

@punker76 punker76 added this to the 1.2.0 milestone Sep 23, 2015
@thoemmi
Copy link
Collaborator

thoemmi commented Sep 24, 2015

Looks good on Windows 10:
image

It's hard to notice on a black background, but I'm fine with that:
image
Inactive state is more recognizable:
image

punker76 added a commit that referenced this pull request Sep 25, 2015
[WIP][RFC] Fix for Glow corners
@punker76 punker76 merged commit cbea676 into master Sep 25, 2015
@punker76 punker76 deleted the glow-corners branch October 22, 2015 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants