Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic theme for window commands, code cleanup... #2152

Merged
merged 1 commit into from
Oct 5, 2015
Merged

Dynamic theme for window commands, code cleanup... #2152

merged 1 commit into from
Oct 5, 2015

Conversation

nikolovjovan
Copy link
Contributor

  • Extracted WindowButtonCommands.xaml and WindowCommands.xaml out of MetroWindow.xaml. Same has been done with the clean style.
  • Added TitleAlignment DependencyProperty to MetroWindow. CleanWindow now uses this property for the centered title.
  • Added ShowLastSeparator and SeparatorHeight properties to WindowCommands. New way of handling items in WindowCommands had to be implemented for the ShowLastSeparator property.
  • Marked WindowMinButtonStyle, WindowMaxButtonStyle and WindowCloseButtonStyle as obsolete. Everything that used these properties has been changed and is now using the new properties from WindowButtonCommands class.
  • Dynamic theme support for both WindowCommands and WindowButtonCommands. The styles of the buttons now change based on the foreground brush. Issue Nasty bug when using OverrideDefaultWindowCommandsBrush #2086 is now fixed.

- Extracted WindowButtonCommands.xaml and WindowCommands.xaml out of MetroWindow.xaml. Same has been done with the clean style.
- Added TitleAlignment DependencyProperty to MetroWindow. CleanWindow now uses this property for the centered title.
- Added ShowLastSeparator and SeparatorHeight properties to WindowCommands. New way of handling items in WindowCommands had to be implemented for the ShowLastSeparator property.
- Marked WindowMinButtonStyle, WindowMaxButtonStyle and WindowCloseButtonStyle as obsolete. Everything that used these properties has been changed and is now using the new properties from WindowButtonCommands class.
- Dynamic theme support for both WindowCommands and WindowButtonCommands. The styles of the buttons now change based on the foreground brush. Issue #2086 is now fixed.
punker76 added a commit that referenced this pull request Oct 5, 2015
Dynamic theme for window commands, code cleanup...
@punker76 punker76 merged commit bc2e194 into MahApps:master Oct 5, 2015
@nikolovjovan nikolovjovan deleted the CustomWindowCommands branch October 5, 2015 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants