NumericUpDown Culture problem #2149 #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@punker76 do you think this can get on the 1.2.0 release? |
| if (this.Culture != null) | ||
| { | ||
| if (textBox.Text.Contains(this.Culture.NumberFormat.NumberDecimalSeparator) == false) | ||
| { |
There was a problem hiding this comment.
It's better to use SpecificCultureInfo property nstead Culture.
|
@fredericoregateiro I will not decide this alone... /cc @xxMUROxx |
|
So, any decision on this one? |
|
@fredericoregateiro sorry, I have forgotten to test this. I will give you then a feedback |
punker76
added a commit
that referenced
this pull request
Dec 2, 2015
NumericUpDown Culture problem #2149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with different cultures and it seems to work just fine.
When the culture NumberDecimalSeparator is ',' (comma) the control replaces the '.' (period or decimal key) with the corrent NumberDecimalSeparator symbol.
All of the remaining functionality is the same.