-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide username on LoginDialog #2230
Conversation
Good point. I went for Visibility mostly because NegativeButton used it. But that does not mean it is appropriate for the Username of course. HideUsername is better. True value results in Collapsed visibility, otherwise Visible. |
@punker76 HideUsername would require a custom BooleanToVisibilityConverter that inverts conversion (true => Collapse and false => Visible). Is this OK, or should we use another property name like ShowUsername or IsUsernameVisible instead? One solution could be to use HideUsername in the LoginDialogSetting but use Visibility for the dependency property. What do you think? |
In general flags should be
|
@mgnslndh can you change your PR to the suggestions? |
@punker76 @thoemmi I can change the PR and use a |
@punker76 I've addressed the suggestions. Does it look OK? |
The LoginDialog can now be shown like this to hide the username and only ask for a password:
Closes #2229