-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fixes in NumericUpDown #2245
Conversation
michaelmairegger
commented
Dec 2, 2015
- NumericUpDown Hexadecimal Issue Not possible to format NumericUpDown value as hexidecimal #1375
- NumericUpDown: UseFloatingWatermark UseFloatingWatermark with the NumericUpDown #2202
- Remove duplicate code in SetTextLength and XXX-GotFocus
- Fixes Bug with Controls:NumericUpDown when setting Maximum programaticaly #1885 (should have been fixed), need feedback from issue-creator
…he displayed value is set to MIN/MAX but the bound value remains still invalid. e.g. Value = 100 bound to MyValue MAX changes to 10 displayed value is 10 MyValue is 100.
35f4bed
to
de37398
Compare
closes: 2202
…dy sets HasTextProperty. I have now changed to TextChanged and PasswordChanged which sets HasTextProperty AND TextLengthProperty.
@punker76: I think this can be merged. |
private static readonly Func<NumericUpDown, Action> NumericUpDownFocus = control => control.SelectAll; | ||
private static readonly Func<PasswordBox, Action> PasswordBoxFocus = control => control.SelectAll; | ||
private static readonly Func<TextBox, Action> TextBoxFocus = control => control.SelectAll; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xxMUROxx do we really need this static
stuff? cause every func is only used once...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@punker76 we could also inline this fields. But what do you think of both generic methods? Should simplify further development if we add UseFloatingWatermark for other controls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But what do you think of both generic methods? Should simplify further development if we add UseFloatingWatermark for other controls.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@punker76 done
<TranslateTransform /> | ||
</TextBlock.RenderTransform> | ||
</TextBlock> | ||
</Grid> | ||
<TextBox x:Name="PART_TextBox" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xxMUROxx can you change the floating message part like in 1919458 ?
thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@punker76 do you mean removing PART_FloatingMessage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xxMUROxx no, i mean changeing Grid -> ContentControl and the tirgger part
…ataGridNumericUpDownColumn the last cell is clicked and AppTheme is BaseLight. Fixes MahApps#2020
[WIP] Some fixes in NumericUpDown