Custom dialogs DialogSettings

[punker76]

What changed?

Some changes to fix #2735 MetroWindow.ShowMetroDialogAsync odd behaviour with provided DialogSettings

Closes #2735

[thoemmi]

Is this ok, or should it be settings = settings ?? (dialog.DialogSettings ?? window.MetroDialogOptions);

[thoemmi]

Looks good to me

[punker76]

It's now possible to do...

• var customBaseMetroDialog = await this.ShowMetroDialogAsync<CustomBaseMetroDialog>();
  creates and shows a new custom dialog of the given type with the default dialog settings
• var customBaseMetroDialog = await this.ShowMetroDialogAsync<CustomBaseMetroDialog>(this.metroDialogSettings);
  creates and shows also a new custom dialog of the given type with own settings

the custom dialog for this samples

<dialogs:CustomDialog x:Class="ShowMetroDialogAsyncIssue.CustomBaseMetroDialog"
      xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
      xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
      xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
      xmlns:dialogs="clr-namespace:MahApps.Metro.Controls.Dialogs;assembly=MahApps.Metro"
      xmlns:d="http://schemas.microsoft.com/expression/blend/2008" 
      mc:Ignorable="d" 
      d:DesignHeight="300" d:DesignWidth="300"
      Title="CustomBaseMetroDialog">
    <StackPanel>
        <TextBlock Text="This is a custom dialog based on BaseMetroDialog" />
        <Button Click="Close_OnClick">Close</Button>
    </StackPanel>
</dialogs:CustomDialog>

namespace ShowMetroDialogAsyncIssue
{
    using System.Windows;
    using MahApps.Metro.Controls;
    using MahApps.Metro.Controls.Dialogs;

    public partial class CustomBaseMetroDialog : CustomDialog
    {
        public CustomBaseMetroDialog()
        {
            InitializeComponent();
        }

        public CustomBaseMetroDialog(MetroDialogSettings settings) : base(settings)
        {
            InitializeComponent();
        }

        public CustomBaseMetroDialog(MetroWindow parentWindow, MetroDialogSettings settings) : base(parentWindow, settings)
        {
            InitializeComponent();
        }

        private void Close_OnClick(object sender, RoutedEventArgs e)
        {
            (this.OwningWindow ?? (MetroWindow)Application.Current.MainWindow).HideMetroDialogAsync(this);
        }
    }
}

Or

• await this.ShowMetroDialogAsync(new CustomBaseMetroDialog());
  create and show custom dialog with default settings
• await this.ShowMetroDialogAsync(new CustomBaseMetroDialog(this.metroDialogSettings)); or await this.ShowMetroDialogAsync(new CustomBaseMetroDialog(this, this.metroDialogSettings));
  create and show custom dialog with own settings

And..

It's possible to move the settings stuff to the custom dialog itself.

protected override MetroDialogSettings OnGetDialogSettings(MetroDialogSettings settings)
{
    return new MyCustomDialogSettings();
}

/cc @thoemmi

[thoemmi]

I would call this method ConfigureSettings. E.g. in ASP.NET you have methods like ConfigureServices, which allow you to intercept and add additional services. Here it allows the user to intercept and change the settings object.

[punker76]

Thx @thoemmi, naming is not my favorite ;-)

[thoemmi]

There two hard problems in computer science:

• cache invalidation,
• naming things, and
• off-by-1 errors

😉