-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TabControl Underlined TabPanel #2902
Conversation
New property to control the type of the underline which can be TabItem or TabPanel (with TabItem) Add Obsolete tag to IsUnderlined property.
This control can be used for underline scenarios.
Use the new stuff at TabControl (TabControl) and MetroTabControl (MetroTabItem)
Add combobox to handle the new underlined stuff
Could we add one more item to the public enum UnderlinedType
{
None,
AllTabItems,
SelectedTabItem,
TabPanel
} where |
New underline type to show only selected TabItems underlined
@punker76 👍 this is gorgeous!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
HEAVY BREATHING |
And make Underline more crystal
for TabItems, makes the Underline usage a little bit better (no jumpy lines gaps)
New brush attached properties for easy changing the underline brush colors
@punker76 Was this designed to work with |
@amkuchta it's coming... |
@punker76 awesome, no rush. I just didn't know if it was supposed to work or not, and didn't want to open an issue without checking in first. These look great! |
What changed?
This PR adds a new attached property to add a new underlined type for the
TabControl
andMetroTabControl
.Underlined
attached property toTabControlHelper
. This property controls the type of the underline type which can be TabItem or TabPanel (with TabItem).IsUnderlined
obsoleteBrush
attached properties to enable easy changing the underline brushesCloses #2895 [RFC] [Enhancement] Proposed TabControlHelper.IsUnderlined Change