NumericUpDown: Fixes #952 and improve stability #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,7 +85,7 @@ public class NumericUpDown : Control | |||
| #endregion | |||
|
|
|||
| private double _internalIntervalMultiplierForCalculation = DefaultInterval; | |||
| private double _internalLargeChange; | |||
| private double _internalLargeChange = DefaultInterval * 100; | |||
There was a problem hiding this comment.
i think this is better add in the constructor of the instances no ?
There was a problem hiding this comment.
I can, but since DefaultInterval is a const there would be no differences.
There was a problem hiding this comment.
ah ok, if is a const ok :P
…XAML other than the standard ones (C,E,N,F,G)
|
Is this finished? If yes we can merge this and release v0.12.1 ✨ |
|
I will review it in the next few hours and give you the O.K. |
flagbug
added a commit
that referenced
this pull request
Jan 21, 2014
NumericUpDown: Fixes #952 and improve stability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.