Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WDM for newer Ruby versions #29

Merged
merged 4 commits into from
Aug 4, 2024
Merged

Conversation

larskanis
Copy link
Collaborator

This updates several minor topics needed for newer ruby versions.

It also updates the CI to run on newer ruby versions, so that it should be all green like here: https://ci.appveyor.com/project/larskanis/wdm .

Fixes #27
Fixes #28

@Maher4Ever Since you haven't be active since years with this project, may I ask for taking over the maintainership of it? I'm the maintainer of rubyinstaller, so that I have some experience on Windows and interest in the ruby ecosystem on Windows.

and bump minimum ruby version to 2.5
... and pry and devkit gems are not very useful these days.
Kind of:
ext/wdm/rb_monitor.c: In function 'rb_monitor_alloc':
ext/wdm/rb_monitor.c:109:5: warning: 'rb_data_object_wrap_warning' is deprecated: by TypedData [-Wdeprecated-declarations]
  109 |     return Data_Wrap_Struct(self, monitor_mark, monitor_free, wdm_monitor_new());
      |     ^~~~~~
In file included from C:/Ruby34-x64/include/ruby-3.4.0+0/ruby/internal/core.h:27,
                 from C:/Ruby34-x64/include/ruby-3.4.0+0/ruby/ruby.h:29,
                 from C:/Ruby34-x64/include/ruby-3.4.0+0/ruby.h:38,
                 from ../../../../ext/wdm/wdm.h:22,
                 from ../../../../ext/wdm/rb_monitor.c:1:
@Maher4Ever
Copy link
Owner

@larskanis Thank you for this PR. Also thank you for maintaining rubyinstaller which I've used years back.

Indeed I'm not involved with the Ruby community anymore, so I'd be very glad if WDM got a maintainer who's interested in taking care of it. I just added you as a collaborator on this repo. If you share your rubygems.org username with me I'll ensure you can manage distribution there as well.

@larskanis
Copy link
Collaborator Author

This gem is used quite often in the ruby ecosystem, so I'm glad you're still available and willing to transfer ownership.

My profile on rubygems is here: https://rubygems.org/profiles/larskanis

The gem push permission can be enabled on the command line by either

gem owner wdm -a lars@greiz-reinsdorf.de

or on the web on: https://rubygems.org/gems/wdm/owners

@larskanis larskanis merged commit d2bc549 into Maher4Ever:master Aug 4, 2024
@Maher4Ever
Copy link
Owner

@larskanis You should have push permissions on rubygems.org now. Good luck with the maintainership!

@johnnyshields
Copy link

@larskanis much appreciated!! You da man!!

@larskanis
Copy link
Collaborator Author

@Maher4Ever Thank you for your quick reaction! Everything worked great, so that I've pushed wdm-0.2.0 today.

@Maher4Ever
Copy link
Owner

@larskanis My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants