Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
query
function was always a bit of a hack to automatically typepql
options based on the method you were calling.For example, instead of:
You could write something simpler, like:
With the above you didn't need to specify the
LineItemService.LineItems
type for the pql function... it was automatically figured out for you by the return type ofgetLineItemsByStatementAsync
. The only problem with this, however, is that you had to know of the function "getLineItemsByStatementAsync".This PR adds a very similar function called "getByStatement" which doesn't require the full function name... just the item name, plus we provide the available items as a union to make things even easier.