Skip to content

Commit

Permalink
Fix ecdfplot test now that Makie can color it correctly again (#559)
Browse files Browse the repository at this point in the history
  • Loading branch information
jkrumbiegel authored Sep 16, 2024
1 parent f117480 commit e63bba3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test/reference_tests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -647,11 +647,11 @@ reftest("ecdfplot") do
group = repeat(["A", "B"], inner = 50)
spec1 = data((; x)) * mapping(:x) * visual(ECDFPlot)
# attributes for ecdfplot currently don't work in Makie, add back to test when they do
# spec2 = data((; x, group)) * mapping(:x, color = :group) * visual(ECDFPlot)
spec2 = data((; x, group)) * mapping(:x, color = :group) * visual(ECDFPlot)
f = Figure()
draw!(f[1, 1], spec1)
# fg = draw!(f[2, 1], spec2)
# legend!(f[2, 2], fg)
fg = draw!(f[2, 1], spec2)
legend!(f[2, 2], fg)
f
end

Expand Down
Binary file modified test/reference_tests/ecdfplot ref.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit e63bba3

Please sign in to comment.