Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colormap theming fixes #194

Merged
merged 4 commits into from
May 25, 2021
Merged

colormap theming fixes #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39da7f4
bump patch number
piever May 25, 2021
cec3296
relax Makie compat
piever May 25, 2021
b3cf032
fix colormap theming
piever May 25, 2021
aa4c0fc
tweak docs ci
piever May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,10 @@ jobs:
version: '1'
- run: |
julia --project=docs -e '
using Pkg; Pkg.develop(PackageSpec(path=pwd()));
using Pkg;
Pkg.add(url="https://github.com/JuliaPlots/Makie.jl", rev="master");
Pkg.add(url="https://github.com/JuliaDocs/Documenter.jl", rev="master");
Pkg.develop(PackageSpec(path=pwd()));
Pkg.instantiate()'
- run: |
julia --project=docs -e '
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "AlgebraOfGraphics"
uuid = "cbdf2221-f076-402e-a563-3d30da359d67"
authors = ["Pietro Vertechi <pietro.vertechi@veos.digital>"]
version = "0.4.1"
version = "0.4.2"

[deps]
Colors = "5ae59095-9a9b-59fe-a467-6f913c188581"
Expand Down
1 change: 1 addition & 0 deletions docs/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ GeometryBasics = "5c1252a2-5f33-56bf-86c9-59e7332b4326"
Glob = "c27321d9-0574-5035-807b-f59d2c89b15c"
LIBSVM = "b1bec4e5-fd48-53fe-b0cb-9723c09d164b"
Literate = "98b081ad-f1c9-55d3-8b20-4c87d4299306"
Makie = "ee78f7c6-11fb-53f2-987a-cfe4a2b5a57a"
PalmerPenguins = "8b842266-38fa-440a-9b57-31493939ab85"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
Shapefile = "8e980c4a-a4fe-5da2-b3a7-4b4b0353a2f4"
Expand Down
2 changes: 1 addition & 1 deletion src/guides/legend.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function _Colorbar_(fg::FigureGrid)
labeledcolorbar = getlabeledcolorbar(grid)
isnothing(labeledcolorbar) && return
label, colorscale = labeledcolorbar
colormap = current_default_theme().Colorbar.colormap[]
colormap = current_default_theme().colormap[]
for entry in entries(grid)
colormap = to_value(get(entry.attributes, :colormap, colormap))
end
Expand Down
1 change: 0 additions & 1 deletion src/theme.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ function aog_theme(; fonts=[firasans("Medium"), firasans("Light")])
titlefont=mediumfont,
)
Colorbar = (
colormap=:batlow,
flip_vertical_label=true,
spinewidth=0,
ticklabelfont=lightfont,
Expand Down