Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support makie v0.19 #440

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Support makie v0.19 #440

merged 2 commits into from
Dec 5, 2022

Conversation

cossio
Copy link
Contributor

@cossio cossio commented Dec 3, 2022

Makie v0.19 was just released with this breaking change (https://github.com/MakieOrg/Makie.jl/blob/master/NEWS.md#v0190):

Breaking The attribute textsize has been removed everywhere in favor of the attribute fontsize which had also been in use. To migrate, search and replace all uses of textsize to fontsize MakieOrg/Makie.jl#2387.

This PR makes AoG compatible with Make v0.19, and stops supporting previous versions of Makie.

@cossio
Copy link
Contributor Author

cossio commented Dec 4, 2022

As far as I can see, this is not changing the API of AoG itself. Therefore I've bumped the patch version here, i.e., this is not a breaking change in AoG. But please review.

@cossio
Copy link
Contributor Author

cossio commented Dec 5, 2022

@SimonDanisch Did you intend to merge the PR?

@SimonDanisch
Copy link
Member

Yes, thank you :)

@SimonDanisch SimonDanisch merged commit 8d755e8 into MakieOrg:master Dec 5, 2022
@cossio
Copy link
Contributor Author

cossio commented Dec 5, 2022

Thanks! Can you tag a release?

@cossio cossio deleted the makie19 branch December 5, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants