Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js from v16 to v20 (#84) #85

Merged
merged 2 commits into from
May 29, 2024
Merged

Update Node.js from v16 to v20 (#84) #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc9cd33
Update Node.js from v16 to v20 (#84)
yukilabo May 29, 2024
bb8a7b3
fix test-ubuntu-latest fail
yukilabo May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ jobs:
distribution: 'temurin'
java-version: '17'
- name: test install-sdk
run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v16.15.0 && npm install && npm ci && npm run build
run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v20.14.0 && npm install && npm ci && npm run build
working-directory: install-sdk
- name: test emulator-run-cmd
run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v16.15.0 && npm install && npm ci && npm run build
run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v20.14.0 && npm install && npm ci && npm run build
working-directory: emulator-run-cmd
- uses: ./install-sdk
name: install sdk
Expand All @@ -31,6 +31,7 @@ jobs:
tag: default
abi: x86
cmd: adb shell getprop
cmdOptions: -noaudio -no-boot-anim -no-window
bootTimeout: 500
- uses: actions/upload-artifact@v1
with:
Expand All @@ -46,10 +47,10 @@ jobs:
distribution: 'temurin'
java-version: '17'
- name: test install-sdk
run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v16.15.0 && npm install && npm ci && npm run build
run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v20.14.0 && npm install && npm ci && npm run build
working-directory: install-sdk
- name: test emulator-run-cmd
run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v16.15.0 && npm install && npm ci && npm run build
run: npm config delete prefix && source ~/.nvm/nvm.sh && nvm install v20.14.0 && npm install && npm ci && npm run build
working-directory: emulator-run-cmd
- uses: ./install-sdk
name: install sdk
Expand Down
2 changes: 1 addition & 1 deletion emulator-run-cmd/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@ inputs:
description: 'be verbose'
default: 'false'
runs:
using: 'node16'
using: 'node20'
main: 'lib/main.js'
36 changes: 27 additions & 9 deletions emulator-run-cmd/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion emulator-run-cmd/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"devDependencies": {
"@types/jest": "^28.1.4",
"@types/node": "^16.10.0",
"@types/node": "^20.12.12",
"jest": "^28.1.2",
"jest-circus": "^28.1.2",
"ts-jest": "^28.0.5",
Expand Down
2 changes: 1 addition & 1 deletion install-sdk/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ inputs:
description: 'do you accept all current Android licenses?'
default: 'yes'
runs:
using: 'node16'
using: 'node20'
main: 'lib/main.js'
36 changes: 27 additions & 9 deletions install-sdk/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion install-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"devDependencies": {
"@types/jest": "^28.1.4",
"@types/node": "^16.10.0",
"@types/node": "^20.12.12",
"jest": "^28.1.2",
"jest-circus": "^28.1.2",
"ts-jest": "^28.0.5",
Expand Down
2 changes: 1 addition & 1 deletion prepare-for-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
set -ex

for i in emulator-run-cmd install-sdk; do
(cd $i && docker run -it -v $(pwd):/opt/app -w /opt/app node:16 bash -c 'npm install && npm run build && npm prune --production' && git add -f node_modules lib)
(cd $i && docker run -it -v $(pwd):/opt/app -w /opt/app node:20 bash -c 'npm install && npm run build && npm prune --production' && git add -f node_modules lib)
done