Add --adb switch to opt out from auto connecting device to local adb #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2017 13:21
Make it possible to opt out from adb connect The reason was it adb is not always available for current context. In my case, I will use this gem to get a device during jenkins stage in a pipeline.
Fix double slash in stf api URL. It caused 404 response yet successfully obtained the device. However, it made the cli fail and return non success status to shell.
|
a bit late on this, but would it be possible for you to merge with latest master? |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my use case, jenkins pipeline, I would like prepare the test device in one stage and use it for testing on another stage.
It's very useful if we want to use docker and the image cannot cater all dependencies, eg: adb and ruby.
Usage:
stf-client connect --no-adb -f k:vIt also fixes 'Error 404' that keeps on showing (and make the cli return non-success status to shell) even though we were able to get the device.