This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
Added schema validation #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jozsefdamokos
commented
Jul 4, 2024
MalteJanz
reviewed
Jul 4, 2024
There was a problem hiding this comment.
Overall great results for your first Rust code in a more advanced codebase 💪 🎉 .
I just commented with some explanations and more "rusty" ways of doing things. Feel free to apply some of them if they make sense to you.
I guess just causing "panics" is also fine here, as we expect some structure in our api schema and if that isn't there something is really broken
|
Looks like you also want to run |
jozsefdamokos
force-pushed
the
schema-validation
branch
2 times, most recently
from
46f662a
to
394c303
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.