Add developer ovirt-engine-sdk instructions for C compiler errors #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
force-pushed
the
add_ovirt_engine_sdk_instructions
branch
from
204f9a9
to
6d837ff
Compare
Fryguy
reviewed
May 8, 2024
Fryguy
reviewed
May 8, 2024
developer_setup.md
Outdated
| @@ -211,6 +211,22 @@ bin/setup | |||
|
|
|||
| macOS requires platform specific Gems. Run `bundle config specific_platform true` before running `bin/setup`. | |||
|
|
|||
| The ovirt-engine-sdk gem contains C code that generated warnings with older CLANG versions. These warnings are marked as errors in newer CLANG 15 and 16 depending on the CLANG version, architecture, and possibly OS. If this is the case, you can mark these as warnings and not errors to allow installation: | |||
There was a problem hiding this comment.
Suggested change
| The ovirt-engine-sdk gem contains C code that generated warnings with older CLANG versions. These warnings are marked as errors in newer CLANG 15 and 16 depending on the CLANG version, architecture, and possibly OS. If this is the case, you can mark these as warnings and not errors to allow installation: | |
| The ovirt-engine-sdk gem contains C code that generated warnings with older Clang versions. These warnings are marked as errors in newer Clang 15 and 16 depending on the Clang version, architecture, and possibly OS. If this is the case, you can mark these as warnings and not errors to allow installation: |
Fryguy
reviewed
May 8, 2024
developer_setup.md
Outdated
| The ovirt-engine-sdk gem contains C code that generated warnings with older CLANG versions. These warnings are marked as errors in newer CLANG 15 and 16 depending on the CLANG version, architecture, and possibly OS. If this is the case, you can mark these as warnings and not errors to allow installation: | ||
|
|
||
| ``` | ||
| gem install ovirt-engine-sdk -v4.6.0 -- --with-cflags="-Wno-error=incompatible-function-pointer-types -Wno-error=implicit-function-declaration" |
There was a problem hiding this comment.
I'm wondering if we should remove the -v4.6.0 here, since it could apply to future versions too and we don't want to have to keep updating this. Besides, the application seems to use 4.4.1 anyway.
Fryguy
reviewed
May 8, 2024
developer_setup.md
Outdated
Comment on lines
226
to
228
| See https://github.com/oVirt/ovirt-engine-sdk-ruby/issues/14 and https://github.com/oVirt/ovirt-engine-sdk-ruby/issues/11 | ||
|
|
||
| Hopefully, the code in the gem can be resolved to avoid these warnings in the future. |
There was a problem hiding this comment.
Think we can merge these into 1 paragraph.
Suggested change
| See https://github.com/oVirt/ovirt-engine-sdk-ruby/issues/14 and https://github.com/oVirt/ovirt-engine-sdk-ruby/issues/11 | |
| Hopefully, the code in the gem can be resolved to avoid these warnings in the future. | |
| See https://github.com/oVirt/ovirt-engine-sdk-ruby/issues/14 and https://github.com/oVirt/ovirt-engine-sdk-ruby/issues/11. Hopefully, the code in the gem can be resolved to avoid these warnings in the future. |
jrafanie
force-pushed
the
add_ovirt_engine_sdk_instructions
branch
from
7b5062c
to
a2aa259
Compare
Co-authored-by: Jason Frey <fryguy9@gmail.com>
jrafanie
force-pushed
the
add_ovirt_engine_sdk_instructions
branch
from
a2aa259
to
78e02c6
Compare
|
Ok, I believe I included all of the suggestions. |
|
Checked commit jrafanie@78e02c6 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Fryguy
approved these changes
May 8, 2024
github-actions bot
pushed a commit
to ManageIQ/manageiq.github.io
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.