Added azure_tenant_id to API_ALLOWED_ATTRIBUTES #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jntullo With your two PRs we'd add something like this? |
|
@miq-bot add_label enhancement |
|
@juliancheal yup, exactly! LGTM! |
This is a follow on PR from ManageIQ/manageiq#16802 and ManageIQ/manageiq-api#279
|
Checked commit https://github.com/juliancheal/manageiq-providers-azure/commit/1394bf82a4e7a6797063e031e81fbbab0cd1ccf1 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
bronaghs
changed the title
|
@juliancheal - Can the WIP label be removed now? |
juliancheal
changed the title
bronaghs
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow on PR from ManageIQ/manageiq#16802
and ManageIQ/manageiq-api#279