Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update event parser code to deal with amqp messages #127

Merged
merged 5 commits into from
Oct 24, 2017

Conversation

tzumainn
Copy link
Contributor

@tzumainn
Copy link
Contributor Author

@aufi would it be possible to test this out? events aren't working in my openstack install for some reason

@tzumainn tzumainn removed the wip label Oct 23, 2017
@tzumainn tzumainn changed the title [WIP] update event parser code to deal with amqp messages update event parser code to deal with amqp messages Oct 23, 2017
@tzumainn
Copy link
Contributor Author

@aufi I managed to successfully test that events were parsed by manageiq; would you be able to verify on your setup?

@aufi
Copy link
Member

aufi commented Oct 24, 2017

@tzumainn Tested and works for me with Ceilometer Events, but does not work with AMQP Events.

There is an AMQP traffic going to OpenStack, so Event monitor works, but Timelines on Infra Provider page are empty, unfortunately nothing significant in emv.log. I can provide acces to my env if needed.

@aufi
Copy link
Member

aufi commented Oct 24, 2017

@tzumainn AMQP Events don't work even without this PR, I don't consider it as issue for merging.

@miq-bot
Copy link
Member

miq-bot commented Oct 24, 2017

Checked commits tzumainn/manageiq-providers-openstack@e449d86~...29c4339 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 9 offenses detected

app/models/manageiq/providers/openstack/cloud_manager/event_parser.rb

app/models/manageiq/providers/openstack/infra_manager/event_parser.rb

app/models/manageiq/providers/openstack/network_manager/event_parser.rb

@mansam mansam merged commit 3692df0 into ManageIQ:master Oct 24, 2017
@aufi aufi added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 26, 2017
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit e4c69b7be214da2d41f7b0068b673c5f764c6f43
Author: Samuel Lucidi <mansam@csh.rit.edu>
Date:   Tue Oct 24 11:37:28 2017 -0400

    Merge pull request #127 from tzumainn/amqp-message-support
    
    update event parser code to deal with amqp messages
    (cherry picked from commit 3692df049bda7d0262e9ed2583d36f40a3baa3dd)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1506626

@simaishi
Copy link
Contributor

Fine backport (to manageiq repo) details:

$ git log -1
commit e1c93db89f827d6fdf031cbbc4c4f3fb29c2db39
Author: Samuel Lucidi <mansam@csh.rit.edu>
Date:   Tue Oct 24 11:37:28 2017 -0400

    Merge pull request #127 from tzumainn/amqp-message-support
    
    update event parser code to deal with amqp messages
    (cherry picked from commit 3692df049bda7d0262e9ed2583d36f40a3baa3dd)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1506624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants