Handle attempts to delete volumes that have already been deleted #147
Conversation
mansam
force-pushed
the
handle-volume-double-deletion-error
branch
from
222af39
to
9081b6b
Compare
| # NoMethodError here usually means the above block got a nil while checking the volume | ||
| # status, probably because the user already deleted the volume. Assume that's the case | ||
| # and show a reassuring message. | ||
| rescue NoMethodError |
There was a problem hiding this comment.
Hi @mansam , thanks for the PR!
I think there can be other cases when NoMethodError is raised than Volume already queued for deletion.
We can merge this in case of emergency, but I'd like discuss changing the line with_provider_object(&:status) == "in-use" to stop connecting to OpenStack and reading the status information from MIQ database record instead. Do you know if this would be possible? Thanks!
There was a problem hiding this comment.
Probably possible, I'll try it and see if I run into any problems.
This handles an exception that would occur when attempting to delete a volume that was already deleted from the provider, but the deletion was not yet reflected in ManageIQ. The exception is now caught and a nice error message is shown.
mansam
force-pushed
the
handle-volume-double-deletion-error
branch
from
effb3d4
to
4bbbe1c
Compare
|
Checked commits mansam/manageiq-providers-openstack@d4229d7~...4bbbe1c with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Looks good to me, thanks! |
|
It looks that backport is not needed from the BZ, but feel free to update it! |
This handles an exception that would occur when attempting to delete
a volume that was already deleted from the provider, but the deletion
was not yet reflected in ManageIQ. The exception is now caught and
a nice error message is shown.
https://bugzilla.redhat.com/show_bug.cgi?id=1487234