Added keystone_v3_domain_id to api_allowed_attributes method #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow on PR from ManageIQ/manageiq#16802/ and ManageIQ/manageiq-api#279
|
👍 LGTM |
|
Checked commit https://github.com/snecklifter/manageiq-providers-openstack/commit/6eedae1d2e906c8ded13def8d1daf7fbc4c09650 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@blomquisg the test failure seems like it's fixed by #198, which I assume is a fix for something that changed in core. Should be unrelated to this patch. |
snecklifter
added a commit
to snecklifter/ansible
that referenced
this pull request
Jan 24, 2018
Adds the capability to create OpenStack providers. Because one of the parameters, keystone_v3_domain_id, is not currently exposed, it is added as an alias of azure_tenant_id which currently maps to uid_ems. Work is in progress to fix this. ManageIQ/manageiq#16802 ManageIQ/manageiq-api#279 ManageIQ/manageiq-providers-openstack#196
snecklifter
added a commit
to snecklifter/ansible
that referenced
this pull request
Jan 26, 2018
Adds the capability to create OpenStack providers. Because one of the parameters, keystone_v3_domain_id, is not currently exposed, it is added as an alias of azure_tenant_id which currently maps to uid_ems. Work is in progress to fix this. ManageIQ/manageiq#16802 ManageIQ/manageiq-api#279 ManageIQ/manageiq-providers-openstack#196
Lujeni
pushed a commit
to Lujeni/ansible
that referenced
this pull request
Feb 1, 2018
Adds the capability to create OpenStack providers. Because one of the parameters, keystone_v3_domain_id, is not currently exposed, it is added as an alias of azure_tenant_id which currently maps to uid_ems. Work is in progress to fix this. ManageIQ/manageiq#16802 ManageIQ/manageiq-api#279 ManageIQ/manageiq-providers-openstack#196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow on PR from ManageIQ/manageiq#16802/
and ManageIQ/manageiq-api#279
https://bugzilla.redhat.com/show_bug.cgi?id=1669600